Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo clippy instead of the clippy plugin #5102

Closed
wants to merge 1 commit into from

Conversation

oli-obk
Copy link

@oli-obk oli-obk commented May 20, 2018

We don't know how long rustc will keep supporting plugins. So we are removing clippy plugin support in favour of the clippy subcommand

@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

@raskchanky
Copy link
Contributor

I'm not sure that anyone actually uses clippy on this project. We might want to just remove it completely.

@oli-obk
Copy link
Author

oli-obk commented May 21, 2018

Any particular reason for not using it? Breakage? Nightly? Too many lints? At least the latter has been addressed: you can choose to only use the clippy_correctness lint group, that group only lints unambiguously buggy code and has no stylistic or opinionated lints

@eeyun
Copy link
Contributor

eeyun commented Jun 15, 2018

It's not that as much as, we just have never used it. I don't think anyone has it in their workflow, we're using rustfmt extensively and most of us are using RLS in our IDEs + racer and a few other tools. I'd be curious to try clippy out, but its just not part of the common workflow right now. Part of that too is the project follows rust stable, not rust nightly which I think is a requirement for clippy?

@oli-obk
Copy link
Author

oli-obk commented Jun 15, 2018

Indeed, if you are not using it in CI and not in your workflows, removing it entirely and waiting for clippy in rls is the right thing. I'm planning for getting clippy into rls on stable rust by fall, we'll see how that goes.

This PR was mainly meant as a way to prevent the removal of the plugin interface from being a breaking change for you. From you description that's not a problem anyway.

Thanks for the explanations!

@oli-obk oli-obk closed this Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants